brave / muon

[DEPRECATED] Build browsers and browser like applications with HTML, CSS, and JavaScript
https://discord.gg/TcT5tX2
MIT License
971 stars 114 forks source link

Clarify about docs #178

Open 3n-mb opened 7 years ago

3n-mb commented 7 years ago

This says for webPreferences

nodeIntegration Boolean - Whether node integration is enabled. Default is true.

Is "Default is true" part hasn't been changed since forking from an electron, or, is this is a correct depiction of muon current api?

Thank you.

3n-mb commented 7 years ago

Also, may be, it's just my impression, but first paragraph of readme says:

Node is added into the browser process only for security reasons.

Usually we remove node integration for security reasons. Hence, this phrase is mystifying ...

diracdeltas commented 7 years ago

@3n-mb

  1. thttps://github.com/brave/muon/tree/master/docs/api is not updated consistently. nodeIntegration is not available in webPreferences any more.
  2. nodeIntegration is removed from webviews, but node access is still possible from the browser process.
3n-mb commented 7 years ago

@diracdeltas browser process is like main process in electron, is it?

3n-mb commented 7 years ago

I have another question, and it is about global.Buffer. Does this part talk about Buffer availability in a renderer everywhere, or only at a point of running preload?

Thank you.

3n-mb commented 7 years ago

@diracdeltas I had a moment of self-reflection, and this is what I noticed:

Hm-m.