search

brave / muon

[DEPRECATED] Build browsers and browser like applications with HTML, CSS, and JavaScript
https://discord.gg/TcT5tX2
MIT License
971 stars 114 forks source link

Brave `about:` pages not loading in non-default incognito sessions #442

Open diracdeltas opened 6 years ago

diracdeltas commented 6 years ago

As noted in https://github.com/brave/muon/pull/358#issuecomment-355123402, a partition named '' or 'default' will load 'about:' pages just fine, but anything else like 'partition-1' does not. This may be because the Brave extension is not loaded at all in non-default incognito partitions.

Loading about: pages is needed for https://github.com/brave/browser-laptop/pull/10831

riastradh-brave commented 6 years ago

This may become moot after all if we (a) make the Tor toggle independent of the session, so that it can be used in off-the-record mode and in on-the-record mode (i.e., with or without keeping history, local storage, &c.), and (b) instead use site instances to configure the proxy on a per-site basis, as in option 5 of https://github.com/brave/muon/issues/464.

...which is not to say we shouldn't fix this bug!

diracdeltas commented 6 years ago

i think it's still needed for tor because i imagine we will create one session for private tor tabs (tor) and one session for non-private tor tabs (persist:tor)