search

brave / muon

[DEPRECATED] Build browsers and browser like applications with HTML, CSS, and JavaScript
https://discord.gg/TcT5tX2
MIT License
970 stars 114 forks source link

Use new site instance for SessionStorageNamespaceImpl clone when opener_suppressed(noopener) specified #632

Closed darkdh closed 6 years ago

darkdh commented 6 years ago

because WebContentsImpl::CreateNewWindow will use target_url as new site instance

The problem was cloning original site instance cause the inconsistency between original partition and target partition because tor browser context enforce isolation storage so every different site has its own storage partition

fix https://github.com/brave/browser-laptop/issues/14392

Test Plan:

  1. Open tor tab
  2. Visit site contains rel="noopener" href (https://jsfiddle.net/dqokhmsg/)
  3. Click the link
  4. Brave shouldn't crash

Auditors: @bridiver, @bbondy