search

brave / muon

[DEPRECATED] Build browsers and browser like applications with HTML, CSS, and JavaScript
https://discord.gg/TcT5tX2
MIT License
971 stars 114 forks source link

Update incognito session initialization #648

Closed bsclifton closed 6 years ago

bsclifton commented 6 years ago

With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values being registered in a session were changed from an exclusion (ex: which values to NOT put in OverlayUserPrefStore) to an inclusion (ex: which values to PERSIST, even in an incognito profile)

Fixes https://github.com/brave/browser-laptop/issues/15191

bsclifton commented 6 years ago

I renamed the variables/methods to match the renaming done upstream:

AddOverlayPref => RegisterPersistentPref
overlay => persist
overlay_pref_names => persistent_pref_names_

See https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5%5E%21/#F4 for more info