search

brave / omaha

Omaha for brave-browser
Apache License 2.0
20 stars 19 forks source link

Stub installer downloads two setup files under different locations #4

Open srirambv opened 6 years ago

srirambv commented 6 years ago
  1. Download stub installer and run
  2. Open C:\Program Files (x86)\BraveSoftware\Update\Downloadand C:\Program Files (x86)\BraveSoftware\Update\Install
  3. Both locations contains brave_installer-x64.exe file

image

cc: @RyanJarv @mbacchi

RyanJarv commented 6 years ago

Would be curious what the process the installer goes through here, or if maybe one of these is tagged and one isn't.

But mostly curiosity, agreed it's low-priority since the issue is mainly 50mb's of unnecessary(?) space used. (granted some select users may not be happy about that)

RyanJarv commented 6 years ago

@srirambv actually do you mind checking if these disappear after some time (maybe a restart), this might just be the installer cache

srirambv commented 6 years ago

@RyanJarv the setup inside C:\Program Files (x86)\BraveSoftware\Update\Install does get removed after a while but the one inside C:\Program Files (x86)\BraveSoftware\Update\Download\{CB2150F2-595F-4633-891A-E39720CE0531}\67.0.50.14 is retained.

simonhong commented 6 years ago

@srirambv I found that chrome also has same behavior. Need to check why they don't erase in download folder

RyanJarv commented 6 years ago

The installer does a few different things if passed various options, only aware of a handful but could be other ones that would be useful while the app is installed. Might be related to uninstalling as well.

On Wed, Jul 25, 2018 at 1:12 AM, Simon Hong notifications@github.com wrote:

@srirambv https://github.com/srirambv I found that chrome also has same behavior. Need to check why they don't erase in download folder

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brave/omaha/issues/4#issuecomment-407644767, or mute the thread https://github.com/notifications/unsubscribe-auth/AD5BQ9vzW_tXxzfIJMWDBfjX4hjCpyuHks5uKAw3gaJpZM4Vc9A- .