brave / security-action

Composite GitHub CI Action containing the minimal viable security lint for brave repositories

Mozilla Public License 2.0

17 stars 6 forks source link

`char foo = 0;` is not a truncation #382

Open fmarier opened 1 year ago

fmarier commented 1 year ago

Reference: https://github.com/brave/brave-core/pull/20351#discussion_r1343864176 Screenshot from 2023-10-03 11-55-26

Proposed Solution

[ ] Remove the rule
[ ] Fork and improve the rule

bcaller commented 1 year ago

I can fix this

fmarier commented 10 months ago

Another example: https://github.com/brave/brave-core/pull/21150#discussion_r1409470056

fmarier commented 8 months ago

Another example: https://github.com/brave/brave-core/pull/21627#discussion_r1463269211 https://github.com/brave/brave-core/pull/21627/files#diff-31129793237da8d2df67d79731c60843c8f2c0fb19370804728c0a87ad202bdb