brave / star-randsrv

Go wrapper service for the STAR randomness server.
Mozilla Public License 2.0
7 stars 5 forks source link

Bump curve25519-dalek from 4.1.2 to 4.1.3 #345

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps curve25519-dalek from 4.1.2 to 4.1.3.

Commits
  • 5312a03 curve: Bump version to 4.1.3 (#660)
  • b4f9e4d SECURITY: fix timing variability in backend/serial/u32/scalar.rs (#661)
  • 415892a SECURITY: fix timing variability in backend/serial/u64/scalar.rs (#659)
  • 56bf398 Updates license field to valid SPDX format (#647)
  • 9252fa5 Mitigate check-cfg until MSRV 1.77 (#652)
  • 1efe6a9 Fix a minor typo in signing.rs (#649)
  • cc3421a Indicate that the rand_core feature is required (#641)
  • 858c4ca Address new nightly clippy unnecessary qualifications (#639)
  • 31ccb67 Remove platforms in favor using CARGO_CFG_TARGET_POINTER_WIDTH (#636)
  • 19c7f4a Fix new nightly redundant import lint warns (#638)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/brave/star-randsrv/network/alerts).
github-actions[bot] commented 3 months ago

[puLL-Merge] - dalek-cryptography/curve25519-dalek@curve25519-4.1.2..curve25519-4.1.3

Description

This pull request introduces several changes focused on code maintenance and optimization for the curve25519-dalek library. It primarily aims to fix a security timing leak, update the license format, improve code organization, clean unnecessary imports, and provide additional methods for enhanced functionality.

Security Hotspots

  1. Timing Leak Fixes:

    • File: curve25519-dalek/src/backend/serial/u32/scalar.rs, curve25519-dalek/src/backend/serial/u64/scalar.rs
    • Details: Changes include the use of an optimization barrier (black_box) to prevent the compiler from inserting branch instructions. This is intended to mitigate timing attacks. The use of black_box here should be reviewed carefully to ensure it effectively provides constant-time operations.
  2. Environment Variable Handling:

    • File: curve25519-dalek/build.rs
    • Details: Enhanced handling of environment variables with clear warnings and error messages. While these changes improve robustness, they should be validated to ensure no unintended information leakage occurs through environment variables.
Changes ### Changes #### `curve25519-dalek-derive/Cargo.toml` - Updated the license format to "MIT OR Apache-2.0" for better SPDX conformance. #### `curve25519-dalek-derive/tests/tests.rs` - Removed functions and tests under the `#[cfg(feature = "dummy")]` configuration, which are no longer used. #### `curve25519-dalek/CHANGELOG.md` - Added entries for version `4.1.3`, documenting a security fix for timing leaks and the resolution of assorted warnings and lints. #### `curve25519-dalek/Cargo.toml` - Updated package version from `4.1.2` to `4.1.3`. - Removed `platforms` as a build dependency. #### `curve25519-dalek/build.rs` - Added a `Display` implementation for `DalekBits` for improved logging. - Reorganized the code to fetch the `target_arch` before backend determination. - Refactored `determine_curve25519_dalek_bits` to accept `target_arch` and adjusted error messages for clarity. #### `curve25519-dalek/src/backend/mod.rs` - Simplified path imports by removing redundant `self::`. #### `curve25519-dalek/src/backend/serial/curve_models/mod.rs` - Simplified `Debug` implementations by removing `::core::` prefix. #### `curve25519-dalek/src/backend/serial/fiat_u32/field.rs` - Improved `Debug` implementation. #### `curve25519-dalek/src/backend/serial/fiat_u64/field.rs` - Improved `Debug` implementation. #### `curve25519-dalek/src/backend/serial/scalar_mul/pippenger.rs` - Removed unused import. #### `curve25519-dalek/src/backend/serial/u32/field.rs` - Improved `Debug` implementation. #### `curve25519-dalek/src/backend/serial/u32/scalar.rs` - Added `black_box` function to ensure the subtraction operation is constant-time. #### `curve25519-dalek/src/backend/serial/u64/field.rs` - Improved `Debug` implementation. #### `curve25519-dalek/src/backend/serial/u64/scalar.rs` - Added `black_box` function to ensure the subtraction operation is constant-time. #### `curve25519-dalek/src/backend/vector/avx2/edwards.rs` - Removed unused import. #### `curve25519-dalek/src/edwards.rs` - Cleaned up unnecessary imports and simplified `Debug` implementations. #### `curve25519-dalek/src/field.rs` - Cleaned up unnecessary imports. #### `curve25519-dalek/src/lib.rs` - Added `allow(unexpected_cfgs)` attribute for compatibility with latest code. #### `curve25519-dalek/src/ristretto.rs` - Improved `Debug` implementations and cleaned up Serde imports. #### `curve25519-dalek/src/scalar.rs` - Cleaned up unnecessary imports and improved `Debug` implementations. #### `curve25519-dalek/src/traits.rs` - Cleaned up unnecessary imports and ensured the `ValidityCheck` trait is properly contained. #### `curve25519-dalek/src/window.rs` - Improved `Debug` implementations. #### `ed25519-dalek/README.md` - Minor grammatical fixes in the README file. #### `ed25519-dalek/src/batch.rs` - Removed unused import. #### `ed25519-dalek/src/lib.rs` - Added inline comment for documentation. #### `ed25519-dalek/src/signature.rs` - Removed unnecessary import and improved `Debug` implementations. #### `ed25519-dalek/src/signing.rs` - Minor code cleanup and improved `Debug` implementations. #### `ed25519-dalek/src/verifying.rs` - Provided methods for the Edwards point conversion and improved `Debug` implementations. #### `ed25519-dalek/tests/ed25519.rs` - Added a test to verify the conversion between Edwards and Montgomery points. #### `x25519-dalek/src/lib.rs` - Removed an unnecessary feature attribute.
dependabot[bot] commented 3 months ago

Looks like curve25519-dalek is up-to-date now, so this is no longer needed.

rillian commented 3 months ago

@dependabot retry?