search

brave / sugarcoat-pipeline

CLI that implements the SugarCoat pipeline
Mozilla Public License 2.0
7 stars 3 forks source link

Bump braces from 3.0.2 to 3.0.3 #61

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Bumps braces from 3.0.2 to 3.0.3.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/brave/sugarcoat-pipeline/network/alerts).
github-actions[bot] commented 5 months ago

[puLL-Merge] - micromatch/braces@3.0.2..3.0.3

Description

This pull request overhauls the ESLint configuration by updating rules for code style and syntax checks. It also modifies various source files to update coding styles, improves the documentation, changes some benchmark tests, and sets a new maximum character limit for input strings.

Possible Issues

  1. Possible Regressions: Changes in the array and object traversal patterns, including the use of const and let, might introduce bugs if not thoroughly tested.
  2. QOL Improvements: The reduction in the maxLength for input strings may affect users relying on longer strings.
Changes ### Changes #### .eslintrc.json - Updates and reorganizes ESLint configuration, changing severity levels, enabling/disabling rules, and switching from `error` to `warn` for many rules. #### .verb.md - Changes the maximum length of the input string from 65536 to 10000. - Fixes some spelling and punctuation errors, and ensures consistent formatting across the file. #### LICENSE - Updates the copyright year to be from 2014 to the present. #### README.md - Updates benchmark results with new test outcomes. - Adjustments in example code snippets to follow the new ESLint rules. #### bench/index.js - Simplifies string interpolation format by removing unnecessary backticks. #### examples/expand.js - Comments out an unused code block without removing functionality. #### examples/option-transform.js - Changes the `transform` function by removing an unused parameter. #### index.js - Replaces `let` with `const` where mutability is not required. #### lib/compile.js - Swaps `let` for `const`. - Adds logging statement for `node.isClose` for debugging purposes. - Modifies how braces and ranges are compiled to adhere to the new ESLint rules. #### lib/constants.js - Decreases the maximum input length to 10000. #### lib/expand.js - Replaces `let` with `const`, improves code structure and adherence to ESLint rules. Also updates range handling to include a strict zero-padding requirement. #### lib/parse.js - Adjustments in handling of inner declarations, while loops, and bracket checks to follow ESLint guidelines. #### lib/stringify.js - Replaces `let` with `const` to indicate immutability. #### lib/utils.js - Utilizes `const` for variables that do not change and simplifies nested iteration logic. #### package.json - Bumps the version to 3.0.3. - Updates `fill-range` dependency version. #### Tests - Updates all test files to match the new coding style enforced by ESLint. - Adds a new test file, test/readme.js, to validate README examples. - Enhances existing tests for edge cases, format consistency, and new ESLint rules compliance.

Security Hotspots

  1. node.isClose Logging: The added logging in lib/compile.js may expose sensitive information in production environments if debugging logs are not properly managed.
  2. MAX_LENGTH Reduction Impact: This change could potentially mitigate some Denial of Service vectors but might disrupt user workflows if longer input strings are expected.

By addressing the points mentioned and ensuring thorough testing, the updates can improve code quality and maintainability while aligning with modern JavaScript standards.