search

brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)
Mozilla Public License 2.0
204 stars 41 forks source link

sync : bookmark order inside of folders is not being maintained #104

Open srirambv opened 7 years ago

srirambv commented 7 years ago

Did you search for similar issues before submitting this one? Yes

Description: When syncing a large data set, with nested subfolders, it was noticed that the order of bookmarks is not being maintained.

Device (iPhone5, iPhone6s plus, iPad 3, ?): iPhone 6s Plus

Brave Version: laptop 0.17.3 & ios 1.4 (17.06.15.13)

Steps to reproduce:

  1. with clean profiles on both devices, configure for sync
  2. import a large amount of bookmarks
  3. check the order of bookmarks in folders after they sync to iOS

Actual Behavior the order of the bookmarks is unintelligible

Expected Behavior the order should match the order on laptop

Is this an issue with Beta build? yes

Is this an issue in the currently released version? no

Can this issue be consistently reproduced? yes

Extra QA steps:

Website problems only:

Screenshot if needed:

screen shot 2017-06-15 at 3 00 23 pm

image uploaded from ios

Any related issues:

alexwykoff commented 7 years ago

@srirambv move back to iOS and retest with latest beta please

diracdeltas commented 7 years ago

is this a dupe of https://github.com/brave/sync/issues/55 ?

alexwykoff commented 7 years ago

This involved imported bookmarks so it may be more related to https://github.com/brave/sync/issues/112

diracdeltas commented 7 years ago

We don't preserve bookmark order yet

LaurenWags commented 7 years ago

Just saw this on Android with the following scenario: Laptop is Pyramid 0, Android is Pyramid 1. Pyramids are synced and both pyramids are open. Import 5k bookmarks on Laptop. About half of the bookmarks were synced to Android (and displayed in order). Closing and reopening both pyramids (first 0, then 1), the remainder of the bookmarks appear to be synced, however those that were added are out of order.

Ex. These bookmarks were synced prior to closing/reopening pyramids: screenshot_2017-07-21-15-36-57

These bookmarks were synced after closing/reopening pyramids. screenshot_2017-07-21-14-54-01

petemill commented 7 years ago

Note that this may be resolved (in browser 0.19.x and latest sync version) as I found that the automated tests which relied on the order being incorrect are now incorrect themselves, and the order is preserved, at least for just a couple of bookmarks in a folder. See https://github.com/brave/browser-laptop/pull/11643