search

brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)
Mozilla Public License 2.0
204 stars 41 forks source link

ipc.send from browser-laptop doesn't work with Uint8Arrays #17

Open diracdeltas opened 7 years ago

diracdeltas commented 7 years ago

if the message contains a Uint8Array, it never gets sent for some reason. sending Uint8Arrays from webview to browser-laptop works fine though.

bridiver commented 7 years ago

not sure I understand. ipcRenderer.send works, but not webContents.send? That seems very odd because the same converters will apply in both directions. Where are you trying to send from?

diracdeltas commented 7 years ago

@bridiver no, ipcMain.send (ex: in browser-laptop app/index.js) doesn't work with Uint8Arrays

bridiver commented 7 years ago

ipcMain.send doesn't go anywhere. What are you trying to send to?

diracdeltas commented 7 years ago

my bad, i meant evt.sender.send in an ipcMain.on handler. see https://github.com/brave/browser-laptop/blob/feature/syncing/app/sync.js#L38 for instance; if you change any of the sent params to a Uint8Array, the send doesn't seem to happen.