No merge on resolve - Githubissues

brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)

Mozilla Public License 2.0

203 stars 54 forks source link

No merge on resolve #353

Closed AlexeyBarabash closed 4 years ago

AlexeyBarabash commented 4 years ago

Fixes https://github.com/brave/sync/issues/261

With this PR resolve operation becomes much simpler. No merge is performed, always wins the latest record. From the other side, now the lib could not accept partial records, for example UPDATE record for bookmark with the only title field change, all fields should be specified even ones which remain the same.

bridiver commented 4 years ago

To be clear, partial updates were never intended to be supported and unnecessarily complicated the implementation

AlexeyBarabash commented 4 years ago

Closing as moving to sync v2