brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)
Mozilla Public License 2.0
203 stars 54 forks source link

Provide callback for SEND_SYNC_RECORDS #356

Closed darkdh closed 4 years ago

darkdh commented 4 years ago

Currently clients of the library won't know if SEND_SYNC_RECORDS is successful or not and they rely on results of SQS in preparing response of GET_EXISTING_OBJECTS to acknowledge that the previous sent record is successfully uploaded to s3. It is easy for client not to get this ack and leads to resend forever. So we should acknowledge the result by callback of s3 PUT