search

brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)
Mozilla Public License 2.0
204 stars 41 forks source link

Introduce device id v2 #362

Closed darkdh closed 4 years ago

darkdh commented 4 years ago

fix https://github.com/brave/sync/issues/333

This PR introduce device id v2 which is a 3 random bytes hex encoded string. We also keep device id for backward compatibility. Migration from existing device would be:

  1. There will be extra SAVE_INIT_DATA for updating device id v2
  2. Create new SQS queues using device id v2 and subscribe to old SQS queues created by device id
  3. We will fetch from both queues for 24 hours and then delete the old queues
AlexeyBarabash commented 4 years ago

Minor notice https://github.com/brave/sync/pull/362/commits/4e5ed880e4577ffb4d2992c7c116d01e78adcdb8 may be squashed before merge, unless there is a hope it will be helpful somehow.

All the rest looks good.