Revert resolutions file entry fix for minimist (master)

brave / sync

deprecated Brave sync server. (sync now uses a fork of the Chromium sync protocol.)

Mozilla Public License 2.0

204 stars 41 forks source link

Revert resolutions file entry fix for minimist (master) #378

Closed bsclifton closed 4 years ago

bsclifton commented 4 years ago

Strategy attempted in https://github.com/brave/security/issues/101 caused complexities with brave-core-crx-packager (via https-everywhere-updater) unfortunately, through the tangled mess of dependencies ☹️

Revert "Merge pull request #375 from brave/bsc-fix-npm"

This reverts commit f4b71bac02bde90178bf6b9c25c5d54e690a3c08, reversing changes made to 4428f605acd31542387bfa8956dda28becaec650.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

bsclifton commented 4 years ago

Thanks for approval, @diracdeltas - quick heads up: I had to temporarily disable Require status checks to pass before merging specifically for continuous-integration/travis-ci on master to allow merge. I re-enabled after merge was done 👍