brave / vault

Brave personal data store vault.
https://brave.com
Mozilla Public License 2.0
19 stars 18 forks source link

Integration #23

Closed mrose17 closed 8 years ago

mrose17 commented 8 years ago

for review, please do not commit yet... thanks!

KevinGrandon commented 8 years ago

Looks great :+1:

I would like to remove the duplicate documentation in the README for the comments that you've moved into hapi.

Also, please rebase against master with git rebase -i master. We should try to remove the merge commits before merging this. Land when you're ready!

mrose17 commented 8 years ago

@KevinGrandon - updates in, please confirm ready for merge after rebase. thanks!

KevinGrandon commented 8 years ago

Looks great! Please rebase if you can and merge. Thanks!

mrose17 commented 8 years ago

OBE!