search

brave / vault

Brave personal data store vault.
https://brave.com
Mozilla Public License 2.0
19 stars 18 forks source link

[testing] initial testing framework #26

Closed mrose17 closed 8 years ago

mrose17 commented 8 years ago

for your consideration... please do not commit (yet)

bbondy commented 8 years ago

Drive by comment, woohoo! Glad to see this happening.

mrose17 commented 8 years ago

thanks... you would not believe what a pain it was to get the babel stuff to work with lab. apparently both trees are in a state of flux at the moment in which the code/docs don't match. sigh!

KevinGrandon commented 8 years ago

This looks like a great start, thanks for putting this together! :+1:

I was unable to run these locally, I think I'm having some trouble with the babel step, perhaps it will work after a shrinkwrap.

I'm not too happy with how this testing framework requires you to handle the transform yourself, instead of being able to just run in a babel-node context. It feels that mocha might be easier to work with because of this. If it's already working though, I'm fine going forward with something like this.

I would ideally like to get this running locally before we land though. The current issue I'm seeing is:

Error: Cannot find module 'babel/node_modules/babel-core'

KevinGrandon commented 8 years ago

Merged /w travis support here: https://github.com/brave/vault/pull/27