brave / vault

Brave personal data store vault.
https://brave.com
Mozilla Public License 2.0
19 stars 18 forks source link

Consider Hapi + Babel + Await #3

Closed KevinGrandon closed 8 years ago

KevinGrandon commented 9 years ago

I've been told that this is a winning combination, and using babel and await should be less memory overhead than koa.

Now that we have something basic, I think it's worth a PoC to see what the differences are, and to make sure that we have a solid foundation.

bbondy commented 9 years ago

https://github.com/ide/hapi-async-handler ?

KevinGrandon commented 9 years ago

I haven't tried it, but we can give it a shot. Code also looks super simple: https://github.com/ide/hapi-async-handler/blob/master/src/index.js

bbondy commented 9 years ago

The repo doesn't look very popular though, maybe just using babel directly

bbondy commented 9 years ago

I'm also wondering if this recommended setup uses babel-node for on the fly transcompilation or if it uses node. I'm assuming it has a build step so that it's not slower? Maybe you can ask your contact?

KevinGrandon commented 9 years ago

I think we should use babel-node for local development, and use a build step/pre-compiled slug if we stay on heroku.

KevinGrandon commented 8 years ago

This is done!