braver / isotope-ui

A UI theme for Atom
MIT License
55 stars 13 forks source link

Theme color selection #11

Closed malexandre closed 9 years ago

malexandre commented 9 years ago

It would be nice to be able to select the theme color. I'm not sure but I think right now it's calculated regarding the hue & other things from the current syntax background color. But one thing that's awesome with Atom is that you can overwrite that. And if I overwrite it in my styles.less, it's not managed by Isotope.

For example, this is the result with my background image (almost totally black): Screenshot The "green on white" is not really something I like. And as you can see, I tried to overwrite your value, but I knew it wasn't working.

Keeping your way to manage all the UI colors regarding a base color but giving us the choice of the base color would be the best solution I think. For now, I'll just overwrite in the styles.less for the Isotope colors too.

braver commented 9 years ago

Yes, definitely want this. There was this discussion recently, but as concluded there, there is currently no elegant way to influence the variables that are used in LESS.

So there's two todo's here:

braver commented 9 years ago

https://github.com/atom/settings-view/pull/275 Has been closed, currently doesn't look like there's going to be a way to change less variables through config. This means there really is no way for me to realise what you're proposing: I can't get a custom color into the stylesheet.