search

braver / isotope-ui

A UI theme for Atom
MIT License
55 stars 13 forks source link

Two-lines overlay looks weird #16

Closed vapask closed 9 years ago

vapask commented 9 years ago

Sometimes it is not possible to use go-to-definition overlay

2015 01 30-19 18 47

braver commented 9 years ago

@vapask Could you clarify what about it is not possible? Does it not work? Is there a layout issue? What I'm seeing is that sometimes the definition name is too long and the line number will scroll out of view.

vapask commented 9 years ago

It works, but it is useless.

for example ctrl+r in big file: 2015 01 30-21 28 42

if I set .list-group li height to auto, .first-line, .second-line display to block, then it looks like this: 2015 01 30-21 33 38 which is much more useful

braver commented 9 years ago

Oh, right, that is obvious then. This isn't covered in the style guide so I didn't catch that before. Thanks for reporting, I'll look into a fix.

braver commented 9 years ago

Fixed in https://github.com/braver/isotope-ui/commit/31a33a746bd4b19bece9654a4ec1269678cd415e and will be released this weekend.

vapask commented 9 years ago

Awesome! Thank you.