Fix: correct usage of channels map

braverhealth / phoenix-socket-dart

Cross-platform and stream-based implementation of Phoenix Sockets

https://pub.dev/packages/phoenix_socket

BSD 3-Clause "New" or "Revised" License

73 stars 37 forks source link

Closed itxtoledo closed 6 months ago

itxtoledo commented 1 year ago

I noticed that the map channels comment says:

 /// [Map] of topic names to [PhoenixChannel] instances being
 /// maintained and tracked by the socket.

But what we see before this PR is a numerical reference to channels. This PR fixes this.

As a bonus we were able to reduce the time complexity to add new channel from O(n) to O(1)

matehat commented 1 year ago

@itxtoledo Great! Do you mind rebasing on main so we can run the CI check on it?

Thanks a lot for you contributions!

itxtoledo commented 1 year ago

@itxtoledo Great! Do you mind rebasing on main so we can run the CI check on it?

Thanks a lot for you contributions!

done

itxtoledo commented 11 months ago

hey @matehat, are u okay?

itxtoledo commented 10 months ago

Will we ever see this PR merged? @matehat @phildupuis

RodolfoSilva commented 8 months ago

Hello guys.

Will this PR merged? @matehat @phildupuis ?