braverhealth / phoenix-socket-dart

Cross-platform and stream-based implementation of Phoenix Sockets
https://pub.dev/packages/phoenix_socket
BSD 3-Clause "New" or "Revised" License
73 stars 37 forks source link

Refactor: Reduce reliance of the package on 3rd party dependencies #72

Closed TesteurManiak closed 4 months ago

TesteurManiak commented 5 months ago

I'm seeing that this package has a lot of 3rd party dependencies that could be avoided. This is not good as some might conflict in projects that also depend on it (and it might also make the maintenance more cumbersome). This PR aims to reduce the number of dependencies to its bare minimum.

Removed dependencies

I've also bumped the version of the dev dependencies and bumped the minimum version of the Dart SDK to 3.0.0 so pattern matching can be used.

TesteurManiak commented 5 months ago

I'm not sure if you should get rid of the collection package.

collection was only used for firstWhereOrNull, I don't really see the dependency should be kept for such a simple extension. 🤔