braverock / FactorAnalytics

67 stars 63 forks source link

-R CMD Check NOTE: checking R code for possible problems #32

Closed JustinMShea closed 2 years ago

JustinMShea commented 3 years ago

plot.ffm: no visible binding for global variable ‘TICKER’ plot.ffm: no visible global function definition for ‘chart.Boxplot’ plot.ffm: no visible global function definition for ‘corrplot.mixed’ plot.tsfm: no visible global function definition for ‘addLegend’ plot.tsfm: no visible global function definition for ‘efp’ plot.tsfm: no visible global function definition for ‘rollapply’ plot.tsfm: no visible global function definition for ‘corrplot.mixed’

Undefined global functions or variables: TICKER addLegend chart.Boxplot corrplot.mixed efp rollapply

JustinMShea commented 2 years ago

Hey @midoshammaa , look like a bunch of these are tied to the fitFfmDT.R file. If you could help with that, it would be very helpful. In the interim, I'll work on the rest of these that aren't related to fitFfmDT.

Thanks!

JustinMShea commented 2 years ago

Some documentation on handling this in general, and related to use of data.table in fitFfmDT and related functions

JustinMShea commented 2 years ago

Hey @midoshammaa , look like a bunch of these are tied to the fitFfmDT.R file. If you could help with that, it would be very helpful. In the interim, I'll work on the rest of these that aren't related to fitFfmDT.

Thanks!

@midoshammaa You can disregard, I have solved the data.table related issues for this! (though not the ERROR being thrown by R_matrix, etc)