braverock / blotter

blotter provides transaction infrastructure for defining transactions, portfolios and accounts for trading systems and simulation. Provides portfolio support for multi-asset class and multi-currency portfolios. Actively maintained and developed.
114 stars 50 forks source link

Add 'Dates' parameter to tradeStats and dailyStats functions #116

Open evgeniavolkova opened 2 years ago

joshuaulrich commented 2 years ago

Hi! Thanks for your work to make this change. Could you please keep them all in one PR? You've opened and closed 2 other PRs for the same purpose (#114, #115), and they have the same commits.

You can keep adding new commits to this PR if you find other changes you need to make. There's no reason to open a new PR with the same commits if you only need to add some new commits... to fix build errors, for example.

evgeniavolkova commented 2 years ago

Hi!

Sorry, it was an accident. Won't do it again.

ср, 16 февр. 2022 г., 19:44 Joshua Ulrich @.***>:

Hi! Thanks for your work to make this change. Could you please keep them all in one PR? You've opened and closed 2 others for the same purpose (

114 https://github.com/braverock/blotter/pull/114, #115

https://github.com/braverock/blotter/pull/115), and they have the same commits.

You can keep adding new commits to this PR if you find other changes you need to make. There's no reason to open a new PR with the same commits if you only need to add some new commits.

— Reply to this email directly, view it on GitHub https://github.com/braverock/blotter/pull/116#issuecomment-1041865047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGC4WMDW2Z2IGBSGODD5C43U3PIAPANCNFSM5OSETGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

joshuaulrich commented 2 years ago

No worries! We can re-open this one if you accidentally close it.