search

braverock / blotter

blotter provides transaction infrastructure for defining transactions, portfolios and accounts for trading systems and simulation. Provides portfolio support for multi-asset class and multi-currency portfolios. Actively maintained and developed.
114 stars 50 forks source link

Address issue #66 #78

Closed vi-to closed 5 years ago

vi-to commented 5 years ago

This PR solves issue #66 consistently with xts plotting facility. The default of the new argument legend.loc is 'bottomright' as @braverock suggested. Possibly I would like to hear opinions on setting it to NULL instead or, better, make graphical modifications so to prevent eventual overlapping with data. In case, I can take care of this.

braverock commented 5 years ago

your commit to chart.ME.R is all whitespace changes. It is generally considered bad form to mess up the whitespace of existing code when changing only a few lines.

It also doesn't make sense to create a second pull request when one already exists in #77. If there are problems with that pull request, they should be addressed there.

vi-to commented 5 years ago

I apologize for the whitespace, I noticed it only once made the PR. About the 2nd topic, I thought it would have been somewhat easier for you to review and eventually merge.

jaymon0703 commented 5 years ago

Pull request #77 resolves issue #66, therefore closing this pull request, thanks @vi-to