Allow Duration Alerts to Repeat (CU-8678tmmew) - Githubissues

bravetechnologycoop / BraveSensor

1 stars 2 forks source link

Allow Duration Alerts to Repeat (CU-8678tmmew) #266

Closed johnny-brave closed 8 months ago

johnny-brave commented 8 months ago

This pull request removes the condition of `!hasDurationAlertBeenSent` when triggering a duration alert. `state2_duration_timer` is also zeroed to the current clock time upon triggering a duration alert.

Test Plan:

[x] set duration timer to 20 seconds and stillness timer to 1 min
[x] close the door sensor and enter occupancy by shaking the test sensor
[x] remain still for 1 minute
[x] verify that 1 stillness alert and 3 duration alerts have been triggered
[x] open and close the door sensor, enter occupancy again
[x] repeat step 3 again, but with movement (staying in state 2)
[x] verify that 3 duration alerts have been triggered and no stillness alert

trisapeace commented 8 months ago

Task linked: CU-8678tmmew Allow Duration Alerts to Repeat

trisapeace commented 8 months ago

When you merge this, can you please use the "Squash and Merge" option? Thank you! That will help keep our commit history readable :smile: