Magnet Side Door Sensor Falling Off Detection (CU-86794et47)

bravetechnologycoop / BraveSensor

1 stars 2 forks source link

Magnet Side Door Sensor Falling Off Detection (CU-86794et47) #279

Closed Darrickg closed 4 months ago

Darrickg commented 4 months ago

This PR adds a feature to detect if the magnet side of the door has fallen off and sends an alert to the client.

Test Plan:

[x] Existing test cases pass
[x] New integration test cases for server side pass
[x] Deployment to dev is successful
- [x] Sent message at original threshold
- [x] Sent message at follow up threshold

Darrickg commented 4 months ago

pushed new changes! lmk if there is anything else you want me to change!

trisapeace commented 4 months ago

Task linked: CU-86794et47 Sentry Alert for when the magnet side of the door sensor falls off

Darrickg commented 4 months ago

@micahdbak should i merge now, even though the translations are possibly off and the variables for the threshold are not discussed yet (they are still arbitrary days that holds no actual meaning or thought)?

Darrickg commented 4 months ago

everything works now, just waiting for @johnny-brave to look everything over before merging

Darrickg commented 4 months ago

Just tested my new changes manually and everything works! Just waiting for Johnny to give me final approval before I merge!