search

bravobit / FFmpeg-Android

FFMpeg/FFprobe compiled for Android
https://bravobit.nl/
MIT License
740 stars 176 forks source link

`sendQuitSignal` also calls `onFailure` instead of `onSuccess`. #90

Open joshuapinter opened 5 years ago

joshuapinter commented 5 years ago

In our case, we're monitoring a live RTSP stream via .sdp and starting and stopping a recording of it. When we stop the recording with ffTask.sendQuitSignal() we actually consider this a success, not a failure.

Is it true that all calls of sendQuitSignal() are considered failures?

If so, do you think that's right and should it be changed?

Thanks!

joshuapinter commented 5 years ago

As a fast-follow to this Issue, I created another PR to add a note to, at the very least, let people know this happens, regardless of the outcome of this Issue. It can be seen here:

https://github.com/bravobit/FFmpeg-Android/pull/91