search

bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
206 stars 45 forks source link

Cleaner error when failing on plugin importing #285

Closed justinnoah closed 13 years ago

justinnoah commented 13 years ago

plugin: cleaner exception output. Uses interface.name instead of just interface.

justinnoah commented 13 years ago

I had the pull request point to my master. It happens to be a moving target, yay. OK so now, the pull request also includes the bed recipe.

MostAwesomeDude commented 13 years ago

Both look good. I'm not a fan of these dual-purpose merges, but I can live with it this time. :3

justinnoah commented 13 years ago

It's what happens when the pull request is set to master rather than a commit.

I can't really seporate commits. If I did them individually, there would be two requests with the first containing the first commit and the second containing the first and second commit.

if you know of a way to do it better, I am all ears!

alucas commented 13 years ago

uh what ?

Make 2 branch and create a pull request for each them.