search

bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
206 stars 45 forks source link

Images URL using config server address in WorldMap #315

Closed lilorox closed 12 years ago

lilorox commented 13 years ago

Hi,

I found a very small bug in the web interface when displaying the WorldMap. I'm using bravoserver with nginx as a proxy and noticed that it was working fine except the display of the WorldMap.

nginx configuration snippet : location /bravo { rewrite /bravo/(.+) /$1 break; proxy_pass http://localhost:8080/; }

The image addresses in /myworld/worldmap are not loading because the URL stays in the form http://localhost:8080/myworld/worldmap/#,#

I'll try to submit a patch when I figure out what is not right ;)

Thanks, LiLoRoX

MostAwesomeDude commented 13 years ago

I remember that those URLs are kinda funky; they should be easy to fix though.

MostAwesomeDude commented 12 years ago

So, I'm looking at the code loading the images, and I'm seeing that they should be loading fine because the code doing the URL generation is client-side. Is this still an issue?

MostAwesomeDude commented 12 years ago

I went back through the history and found that this issue was filed prior to the worldmap being switched to use client-side URL generation. Since I can't reproduce it, I'm marking this as fixed. Reopen if it persists. Thanks!