search

bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
206 stars 45 forks source link

Closing workbench causes unhandled AttributeError exception. #325

Closed mcsakoff closed 13 years ago

mcsakoff commented 13 years ago

File "C:\Python27\lib\site-packages\bravo-1.7.2-py2.7.egg\bravo\protocols\beta.py", line 285, in dataReceived self.handlersheader File "C:\Python27\lib\site-packages\bravo-1.7.2-py2.7.egg\bravo\protocols\beta.py", line 970, in wclose sync_inventories(i, self.player.inventory) File "C:\Python27\lib\site-packages\bravo-1.7.2-py2.7.egg\bravo\inventory.py", line 580, in sync_inventories dst.holdables = src.holdables exceptions.AttributeError: 'int' object has no attribute 'holdables'

Probably copypasted code was not properly changed.

mcsakoff commented 13 years ago

1f60c38 Fixes client crash: java.lang.IndexOutOfBoundsException: Index: 45, Size: 45 at java.util.ArrayList.RangeCheck(ArrayList.java:547) at java.util.ArrayList.get(ArrayList.java:322)

MostAwesomeDude commented 13 years ago

I'm gonna merge this, but in the future, PEP8 compliance would be greatly appreciated. Thanks!