search

bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
206 stars 45 forks source link

Fixed trees and grass automatons #337

Closed gwylim closed 12 years ago

gwylim commented 13 years ago

In the Trees automaton, saplings would grow into trees even after they were removed from the ground (i.e. trees would grow from thin air), due to there not being a check for the block still being a sapling.

In the code to feed newly created blocks to automatons, they were given the coordinates of the block clicked on, instead of the block which was created.

There was a bug in the IDigHook implementation of Grass. Two objects of the class Grass are created: one for IAutomaton, and one for IDigHook. I think the implementation was assuming they were the same object, which I believe they are not.

gwylim commented 13 years ago

With the second commit, #271 seems to work now, at least on my computer.

MostAwesomeDude commented 12 years ago

Okay, so I cherry-picked the offset fix, and wrote simpler versions of the others, handling #271 in the process. That dig_hook improvement should still be pulled in somewhere, but I'm not super-sure where it should go, so I'm gonna punt for now. Thank you so much for looking at this issue; it was a thorn in my side.