bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
205 stars 45 forks source link

Code quality enforcement #385

Closed QualityBot closed 11 years ago

QualityBot commented 11 years ago

Code Quality Enforcement

I'm a bot that determines the most common coding styles in your project and attempts to make that style consistent across your whole repository.

Change Summary

My Source Code | More Information | My Author

If I did something wrong, or if you want more featues, pull requests are always welcome. This is an automated tool, and no human reviewed these changes. Please ensure that they are correct before merging. If they aren't, leaving an issue would be appriciated.

MostAwesomeDude commented 11 years ago

NAK:

This diff is far too large; show me the diff of only converting tabs to spaces.

ddevault commented 11 years ago

Sane tools have a fake buffer extending past the end of the file.

As for spaces/indent, try explicitly stating your requirements in the issue body. Follow instructions in the README.

squiddy commented 11 years ago

As for spaces/indent, try explicitly stating your requirements in the issue body. Follow instructions in the README.

I had to look at your bot's project to see what you're talking about. As far as I know, no one here created an issue for the bot in the first place, it just came here and dropped a huge diff. So now we should create an issue for it to do only what is necessary?

ddevault commented 11 years ago

MostAwesomeDude made the initial request. If you want it to, feel free to make another and explicitly state style guidelines.

ddevault commented 11 years ago

Link to MostAwesomeDude's request

squiddy commented 11 years ago

Oh sorry, didn't know about that.