Closed justinnoah closed 11 years ago
Well, if it passes tests, then it should be fine. On Dec 31, 2012 8:25 PM, "Justin Noah" notifications@github.com wrote:
So, github removed the ability to specify commits for the pull request, only allowing for the head of whichever branch. Anyway, the pull request includes:
.gitignore: some basics that got annoying
bravo/plugins/init.py: addition that allows plugins from other locations see: http://twistedmatrix.com/documents/12.2.0/core/howto/plugin.html#auto2 and: http://docs.python.org/2/library/site.html for details.
Also look at bravo-win/main.py to see how I'm using site.addsitedir().
You can merge this Pull Request by running:
git pull https://github.com/brutal-chaos/bravo master
Or view, comment on, or merge it at:
https://github.com/MostAwesomeDude/bravo/pull/387 Commit Summary
- ignore: dist/ build/ Bravo.egg-info/
- plugins: load plugins from other sitepaths
File Changes
- M .gitignore (3)
- M bravo/plugins/init.py (3)
Patch Links
- https://github.com/MostAwesomeDude/bravo/pull/387.patch
https://github.com/MostAwesomeDude/bravo/pull/387.diff
— Reply to this email directly or view it on GitHubhttps://github.com/MostAwesomeDude/bravo/pull/387.
Nothing changed as far as tests go.
So, github removed the ability to specify commits for the pull request, only allowing for the head of whichever branch. Anyway, the pull request includes:
.gitignore: some basics that got annoying
bravo/plugins/init.py: addition that allows plugins from other locations see: http://twistedmatrix.com/documents/12.2.0/core/howto/plugin.html#auto2 and: http://docs.python.org/2/library/site.html for details.
Also look at bravo-win/main.py to see how I'm using site.addsitedir().