bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol
http://bravoserver.org/
Other
205 stars 45 forks source link

Chunk dirtiness is not always reflected client-side #418

Closed MostAwesomeDude closed 10 years ago

MostAwesomeDude commented 11 years ago

There are broken tests related to this.

MostAwesomeDude commented 10 years ago

First unbroken in b328b4426a2234cde95f74953eabac1132706306, and fixed in a more permanent way in 92ea0f308b084ea762cadaad8937b58fda4c7210. This was caused by chunks not necessarily being identified as dirty during cache cleaning; since the cleaning was periodic, it was possible for dirty chunks to secretly avoid being discovered and sent to clients.