Tests should not trigger OOB chunk access

bravoserver / bravo

UNMAINTAINED: Reverse-engineered Minecraft stuff. Worked with 1.4.x protocol

http://bravoserver.org/

Other

205 stars 45 forks source link

Tests should not trigger OOB chunk access #423

Closed JeppeKlitgaard closed 11 years ago

JeppeKlitgaard commented 11 years ago

When the server is run (without previous world, haven't tested with), or when running the tests it will continuously _spam_ "Coordinates %s are OOB in %s() of %s, ignoring call"-like messages.

This is because the coordinates fail to the validation going on in chunk.py:34 This is something I think is rather alarming, and should be fixed.

MostAwesomeDude commented 11 years ago

It is definitely alarming, and if I had any gumption to hack on Bravo, I'd go and fix some of them. Patches welcome. Note that this bug cannot ever be closed as worded, but that's okay; somebody will close it when messages get down to an acceptable level.

Edit: Updated title to have a measurable goal.