search

braydie / HowToBeAProgrammer

A guide on how to be a Programmer - originally published by Robert L Read
https://braydie.gitbooks.io/how-to-be-a-programmer/content/
15.9k stars 1.34k forks source link

improve readability in zh #79

Closed aidewoode closed 8 years ago

aidewoode commented 8 years ago

For the readability, I add space between the Chinese and English letter. And I also change some translation to make it easier to understand. Now I just finished the first chapter, and the rest chapter I will do it later.

braydie commented 8 years ago

hey @aidewoode thanks for the contribution! based on some of the feedback in another issue we've had around translations, before merging in I'd like to get a second set of eyes to review the changes you've made (as I can't verify them myself, unfortunately!)

@ahangchen wrote the original translation so they'd be the best person to review I believe

ahangchen commented 8 years ago

@aidewoode For fixes of Chinese version, please open a pull request into this repository https://github.com/ahangchen/HowToBeAProgrammer.

aidewoode commented 8 years ago

@ahangchen Is there any difference between the two repository?, why I should pull another same request to a fork repository?

ahangchen commented 8 years ago

@aidewoode Because Braydie can't review it without understanding Chinese, and this repository is the original translation for Chinese, so I will help to review fixes for Chinese version and finally push them to this repository, as mentioned in this issue #45

aidewoode commented 8 years ago

yeah, I get it, but I think maybe it's not a good idea. Because, first, we have to merge twice for the same purpose, it's seem less efficient. And second, imagine this, when we have others translation version, like Spanish, Japanese or some thing else in the later , and a contributor want to translate some to Chinese, and also want to translate some to Japanese, maybe he also want to change some original English content. If we have fork repository for each translation version, he have to fork at least three repository, and separate one commit to three for the each repository, I think this will made him so sad.

I think in this repository you can review Chinese too, When have some Chinese translation contribution, I think @braydie will mention you, and you can mention others Chinese contributor to review this commit together. I think just contribute to one repository will be simpler.

ahangchen commented 8 years ago

Contributing to one repository is simpler for the contributor, but not for the manager. Solving problems in the corresponding branch is why git is charming. Although we have to merge twice, it's clearer. By the way, it's unnecessary to fork each translation version, actually, github will prevent you from doing this. You can open a PR to any branch by simply choosing the base fork in the PR page.

aidewoode commented 8 years ago

@ahangchen all right, I will push another quest , and this PR will be closed

braydie commented 8 years ago

I agree with both of you on this - it makes sense to have a single repository for ease of contribution but is difficult to manage, particularly as it is just me at the moment. Perhaps the solution to this would be making the person who makes the initial contribution of a translation an official contributor for this project, that way they can manage pull requests that come through for 'their' language