search

braz96 / skin.mimic

A Kodi skin with touches of reFocus and Aeon Nox.
Other
80 stars 67 forks source link

Global Wallpaper #9

Closed 0x466162 closed 9 years ago

0x466162 commented 9 years ago

Hi,

this lays the foundation to configure a global wallpaper for each and every menu you are in. At the moment you can't configure it via the gui but you can test it:

kodi-send --action="Skin.SetString(Global.Wallpaper,/path/to/image)" kodi-send --action="ReloadSkin()"

Hope you will integrate this. Frank.

braz96 commented 9 years ago

I'd prefer not to add another method to set the wallpaper. There's already options for setting wallpaper for each menu item and each section. I feel like this would make things more confusing. Better for users to just set each section to the same wallpaper if that's what they want.

You're welcome to share your mod on the forum, I'll link it to the stickied mods post if you do.

0x466162 commented 9 years ago

Seems like you have a good idea about how your skin should look and feel like and that you are hard to convince - which is a good thing.

But I would argue to have the opportunity to set a wallpaper for all of the menus is less confusing than to have to change it for all sub menus separately.

At the moment it is just a variable not a knob. How about not adding a knob but to ask the user if this should be used everywhere when he sets a wallpaper for a sub menu?

Btw. my change allows for different Home Screen Wallpapers on a per profile basis which actually is what I want.

braz96 commented 9 years ago

If you're willing to put together a complete (working) pull request of this feature, I'll test it and consider adding it. There's just not enough to go by in the existing pull request and I don't have time to figure it all out.