search

brazanation / php-documents

Library to provide Brazilian Documents as Value Objects in PHP
212 stars 22 forks source link

Using respect validation? #4

Open royopa opened 8 years ago

royopa commented 8 years ago

What do you think about use the Respect Validation Library as a requirement for this project? Example: Maybe use the Respect Validation as a requirement in composer and return a exception when v::cpf()->validate('02650306461'); return false.

https://github.com/Respect/Validation/blob/master/docs/Cnh.md https://github.com/Respect/Validation/blob/master/docs/Cpf.md https://github.com/Respect/Validation/blob/master/docs/Cnpj.md

tonicospinelli commented 8 years ago

I thinking about it and Respect\Validation component is awesome.

So, I have doubts about responsibility in this case, I don't know if documents validation must be done from Respect\Validation or maybe this document component integrates with Respect\Validation.

Maybe move Modulo11 to Respect\Validation, because this class has a configurable rule to validate numbers.

ping @alganet @augustohp