Open internetisaiah opened 1 week ago
I think @bre-fitzgerald would be a great person to take point on reviewing this, if she has the bandwidth! I'll let her make the call if she does, yea or nay.
Thanks for putting these in, Isaiah!
I think @bre-fitzgerald would be a great person to take point on reviewing this, if she has the bandwidth! I'll let her make the call if she does, yea or nay.
Reviewed. Thanks for tackling this @internetisaiah! I left some comments and feedback for your review, but other than the issues I called out this LGTM.
As you mentioned there's a mix of some other commits in here, so feel free to ignore anything that isn't relevant to this PR. It does look like alt text may have gotten removed from a few pages, and there were a few instances where the alt text had typos, so that might be something to investigate with the tool we're using.
hmm, ya @bre-fitzgerald and @josh-mccrowell-braze , there are some very weird things going on with this PR and i'm not sure why. i am going to move my work to a new PR on monday, because i think if i merge this one, its going to overwrite other people's work. For example:
by
back to via
to ensure changes from my specific commits are merged only, i'm going to close this PR out and start a new branch. let me know if you have any other questions/concerns 👍🏽
Why are you making this change? (required)
These are the top pages visited on Braze Docs, so we have decided to ensure that all their images have alt text and any existing alt text does not use directional language.
Related PRs, issues, or features (optional)
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.