search

braze-inc / braze-expo-plugin

Other
11 stars 10 forks source link

Fix build.grade for Expo SDK 50 #27

Closed robwalkerco closed 9 months ago

robwalkerco commented 9 months ago

This PR fixes a build error caused by the build complaining about there being a mismatch between Java 17 (required by Expo SDK 50) and Java 11 (required by this config-plugin)

The fix follows the same approach commonly used by Expos own modules For example https://github.com/expo/expo/blob/8a9b0c33dad957fb136f848dcf267dcb7539be0a/packages/expo-maps/android/build.gradle#L68-L78

jerielng commented 9 months ago

Hey @robwalkerco, we're currently working on implementing these changes internally to support Expo 50 and will update you here as soon as it's released.

For reference, we'll be removing the strict version dependency on Java 11 similar to what we did with our React Native SDK here, so this should be forwards and backwards compatible without having to do a conditional check against the AGP version.

In the meantime, I believe you should be able to workaround this by using your fork for the timebeing.

Please let us know if you have any questions or concerns. Thanks!

robwalkerco commented 9 months ago

Thanks for your response. It's great that you are working on updating the library.

I'll use continue to use my patch-package patch in the meantime.

ethan-park-is commented 9 months ago

@jerielng Can you tell me the estimated time of release to support Expo 50?

jerielng commented 9 months ago

@jerielng Can you tell me the estimated time of release to support Expo 50?

We hope to have it out sometime within the next two-three weeks.

jerielng commented 9 months ago

Hey all, as mentioned in #26, version 2.0.0 has been released, which should address these concerns. Thank you!