search

braze-inc / braze-flutter-sdk

Public repo for the Braze Flutter SDK
Other
15 stars 29 forks source link

adding message type, and making sure message type doesn't get overriden #64

Open EssentialsDev opened 4 months ago

EssentialsDev commented 4 months ago

The "html" message type was missing causing "slideup" to get returned.

Also when using the "full" type it would loop thru to the "html_full" and return that since it ends with "full"

WillNeill commented 1 month ago

Hi @hokstuff, just seeing if this is something you're looking to review and merge anytime soon? Thank

hokstuff commented 1 month ago

Hi, so I fully understand this proposed change, can you add more context in what the expected behavior is as well as the actual behavior you are seeing? Can you also attach the campaign you are using that you're running into issues with? (If you're more comfortable, feel free to contact support@braze.com with the information)

I have some concerns with the code that is added, so I would like to understand the root of the problem and then make the change internally: Re: This line - Rather than use the endsWith, it probably would be more accurate to compare each string directly