search

braze-inc / braze-react-native-sdk

Public repo for the Braze React Native SDK
https://www.braze.com
Other
64 stars 84 forks source link

Delete noop functions setSDKFlavor and setMetadata #210

Closed cltnschlosser closed 1 year ago

cltnschlosser commented 1 year ago

Delete noop functions setSDKFlavor and setMetadata. They did nothing, but log on iOS. This was never exposed to end users, so it's not a breaking change.

jerielng commented 1 year ago

Hi @cltnschlosser Thank you for raising this change request! Sorry to hear that you have observed excessive logging from your end.

We'll take a look at these functions and adjust our API as needed. Note that any consequent release will come through our private repository and review process. Additionally, we may still likely label such a release as a breaking one to follow SemVer conventions.

In the meantime, you can also mitigate the logging by lowering the Braze logging level in your application.

Let us know if you have any questions. Thanks!

hokstuff commented 1 year ago

Hi @cltnschlosser,

We have incorporated your changes into the latest 5.0.0 release. Thank you for submitting a pull request!