braze-inc / braze-swift-sdk

Braze SDK for the Apple ecosystem, including: iOS, macOS, iPadOS, visionOS, tvOS
https://www.braze.com
Other
52 stars 19 forks source link

[Bug]: Xcode 15.3 and App Store Connect Issue #112

Closed gooson closed 8 months ago

gooson commented 8 months ago

Platform

iOS

Platform Version

iOS 17.4

Braze SDK Version

8.1.0

Xcode Version

Xcode 15.3

Computer Processor

Apple (M1)

Repro Rate

100%

Steps To Reproduce

Archive app and upload it to the App Store.

스크린샷 2024-03-08 오전 11 21 34

Expected Behavior

Expect successful upload to App Store Connect

Actual Incorrect Behavior

upload failed

Asset validation failed Invalid Bundle. The bundle KREAM Inhouse.app/Frameworks/BrazeKit.framework does not support the minimum OS Version specified in the Info.plist. (ID: 6b5c0795-e051-4c78-b7b1-a0e52567645c)

Asset validation failed Invalid Bundle. The bundle KREAM Inhouse.app/Frameworks/BrazeLocation.framework does not support the minimum OS Version specified in the Info.plist. (ID: aa07ed5a-007d-4fa0-a82e-8aacc98ef36e)

Verbose Logs

Asset validation failed
Invalid Bundle. The bundle KREAM Inhouse.app/Frameworks/BrazeKit.framework does not support the minimum OS Version specified in the Info.plist. (ID: 6b5c0795-e051-4c78-b7b1-a0e52567645c)

Asset validation failed
Invalid Bundle. The bundle KREAM Inhouse.app/Frameworks/BrazeLocation.framework does not support the minimum OS Version specified in the Info.plist. (ID: aa07ed5a-007d-4fa0-a82e-8aacc98ef36e)

Additional Information

No response

jerielng commented 8 months ago

Hi @gooson, thanks for sharing some additional details around this issue. We have a separate thread in #105, which I saw that you commented on. Although we believe this to be an Xcode bug, this is on our radar, and we'll continue to look into our options.

In the meantime, you can work around this issue by either using Xcode 15.2 or sourcing your Braze SDK from our prebuilt dynamic XCFrameworks repository.

We'll continue to keep you updated. Feel free to keep this issue open, or you may close it if you wish to continue following this topic in #105. Thanks!

jesus-mg-ios commented 8 months ago

Same issue here.

jesus-mg-ios commented 8 months ago

Seems like firebase had the same issue and solved it. https://github.com/firebase/firebase-ios-sdk/issues/12441

stuti7 commented 8 months ago

Same issue here

bstillitano commented 8 months ago

This is breaking our builds also. Any ETA on fixing this?

hokstuff commented 8 months ago

We have made some changes in our private repo that are currently being validated. We will be in touch once it is verified and released! Until then, using Xcode 15.2 or using our prebuilt dynamic xcframework are valid workarounds.

Thanks!

bstillitano commented 8 months ago

What is the ETA on that @hokstuff? That answer seems very vague and raises concerns around how long we'll actually be waiting for this.

We have a hard requirement on Xcode 15.3 so are using the framework. This presents an additional issue, in that we can not use braze-segment-swift anymore because it has a clash with the framework, as that package imports the braze-swift-sdk SPM module as well.

We're essentially at the point where we have to remove the BrazeSDK in order to actually release our app. Can we please get an alpha release or something that can unblock us?

image

hokstuff commented 8 months ago

Hi @gooson @jesus-mg-ios @stuti7 @bstillitano,

We have just released Braze Swift SDK version 8.2.1 which fixes the issues during archiving on Xcode 15.3.

Let us know if you run into any further issues - Thanks!

bstillitano commented 8 months ago

@hokstuff confirming this is working. We did receive an error initially after uploading to ASC saying Uploading IPA failed: signal: segmentation fault however a subsequent build worked. Will report back if any issues. Appreciate the hustle on this.