braze-inc / braze-swift-sdk

https://www.braze.com
Other
48 stars 19 forks source link

[Bug]: Including BrazeKit in tvOS target causes issue with push notification entitlement #113

Open pahnev opened 4 months ago

pahnev commented 4 months ago

Platform

Other

Platform Version

tvOS

Braze SDK Version

8.0.1

Xcode Version

Xcode 15.2

Computer Processor

Apple (M1)

Repro Rate

100%

Steps To Reproduce

Example:

  1. Add basic integration for Braze in AppDelegate.swift
    let config = Braze.Configuration(apiKey: "key", endpoint: "endpoint")
    self.braze = Braze(configuration: config)
  2. Upload the build to TestFlight

Expected Behavior

No issues reported by AppSore Connect.

Actual Incorrect Behavior

AppStore Connect sends an email about an issue in the uploaded build:

ITMS-90078: Missing Push Notification Entitlement - Your app appears to register with the Apple Push Notification service, but the app signature's entitlements do not include the 'aps-environment' entitlement. If your app uses the Apple Push Notification service, make sure your App ID is enabled for Push Notification in the Provisioning Portal, and resubmit after signing your app with a Distribution provisioning profile that includes the 'aps-environment' entitlement. Xcode does not automatically copy the aps-environment entitlement from provisioning profiles at build time. This behavior is intentional. To use this entitlement, either enable Push Notifications in the project editor's Capabilities pane, or manually add the entitlement to your entitlements file. For more information, see https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/HandlingRemoteNotifications.html#//apple_ref/doc/uid/TP40008194-CH6-SW1.

Verbose Logs

No response

Additional Information

Obviously we could add push notification entitlement to the tvOS target to silence this error, but since it doesn't actually support those and neither does the Braze SDK, we shouldn't need to do so.

jacksonemiller commented 4 months ago

Hi, thank you for submitting this. I'd like to ask if you could please file a support issue with support@braze.com. There's a lot more information and context I'd like to have about your code and integration before diving in to investigate this.

Thank you!

jed-alphero commented 4 months ago

Just noting that I have the same problem with our AppleTV app. Similar setup and code as pahnev

jacksonemiller commented 4 months ago

Hey @jed-alphero. The original poster did go ahead and file a support issue, so we've begun tracking it internally and will let you know of any updates as we work on it. Thank you.