search

braze-inc / braze-swift-sdk

Braze SDK for the Apple ecosystem, including: iOS, macOS, iPadOS, visionOS, tvOS
https://www.braze.com
Other
52 stars 19 forks source link

[Feature]: Carthage support for Core feature #24

Open renaudjennymonese opened 1 year ago

renaudjennymonese commented 1 year ago

What problem are you facing?

Any plan to add support for Carthage?

We're currently using the legacy AppBoy Core SDK with more or less this line in our Cartfile

binary "https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk_core.json"

Workarounds

none

Ideal Solution

An equivalent of the binary version but using the Swift SDK as the legacy one (AppBoy) is more or less deprecated. I'd insist on this point, we need the Core only version as we couldn't include SDWebImage/SDWebImage dependency for some reasons.

Thank you

Other Information

No response

Bucimis commented 1 year ago

@renaudjennymonese Hi, the Swift SDK does not have a dependency on SDWebImage. If you would like to use the Core, we offer that in the BrazeKit module through both SPM and Cocoapods - unlike in the legacy SDK, both of these will stand alone and not have an external dependency on SDWebImage. Does that solve your issue, or are you strictly tied to Carthage as a package manager?

renaudjennymonese commented 1 year ago

@Bucimis , that's awesome regarding not relying on SDWebImage! And about Carthage, unfortunately yes we will still use it and indeed we could say that we're strictly tied to Carthage as a package manager, no plan to move to SPM anytime soon for some reasons.

Like I mentioned, having binary "https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk_core.json" equivalent would be the best for us.

Is it possible?

Bucimis commented 1 year ago

@renaudjennymonese we've filed an issue on our end to spike out support for Carthage and will update as we make progress. However, I want to call out that Carthage hasn't been released in 1.5 years and issues are piling up (https://github.com/Carthage/Carthage/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc) - there's a non-trivial chance Carthage will simply not work with our library.

renaudjennymonese commented 1 year ago

@Bucimis , thanks a lot. I do totally understand the distance with Carthage, especially that SPM is more or less the one to go for managing dependencies in an iOS project, and this new SDK is working well with it. Unfortunately for us, it's still not possible to use SPM. Hopefully enabling Carthage from you will work without too much effort. Otherwise yes please, let me know as soon as possible that you won't support Carthage in any point in the future.

Cheers.

kunal30xi commented 1 year ago

We are in the process of updating to the Swift version of the Braze library and would prefer a pre-built Carthage framework. Can we get an ETA on when support will be provided?

cbowns commented 1 year ago

Hi all (@kunal30xi @renaudjennymonese et al.),

Carthage support for our Swift SDK is not currently on our roadmap. While we are still evaluating the compatibility of Carthage with our Swift SDK, we encourage you to explore integrating with one of the supported package managers (SPM + CocoaPods), or manually integrate it using the braze-swift-sdk-prebuilt.zip archive released in v5.9.0 and later.