search

braze-inc / braze-swift-sdk

Braze SDK for the Apple ecosystem, including: iOS, macOS, iPadOS, visionOS, tvOS
https://www.braze.com
Other
52 stars 19 forks source link

Update ABKSdkMetadata.h #56

Closed p-syche closed 1 year ago

p-syche commented 1 year ago

Replace @import statement with #import <Foundation/Foundation.h> in the BrazeKitCompat library

lowip commented 1 year ago

Hi @p-syche,

Thank you for opening this PR. Could you provide a bit more context around the change? Is the @import syntax problematic on your side?

There's another instance of using @import Foundation in BrazeKitCompat, I'm wondering if we would need to update it as well.

hokstuff commented 1 year ago

I am closing out this PR due to inactivity. If you have further questions or concerns around using the existing @import syntax, feel free to reach out to support@braze.com. Thanks!

p-syche commented 1 year ago

Hi @lowip and @hokstuff ,

Sorry fo my inactivity. As for the context: this place was the only one left with the @ import statement in the new SDK. It seemed like a left over from the migration. I found this because this particular @ import caused an issue while building our app that used the new Swift SDK.

jerielng commented 1 year ago

Hi @p-syche, there are a couple of reasons why the @import syntax could cause a build issue. Are you able to share any details about what you are encountering in your project? As @hokstuff mentioned, if you are experiencing a specific scenario with your project, feel free to send in some details and logs to support@braze.com.