braze-inc / braze-swift-sdk

Braze SDK for the Apple ecosystem, including: iOS, macOS, iPadOS, visionOS, tvOS
https://www.braze.com
Other
52 stars 19 forks source link

[Bug]: App crash on ABKFeedWebViewController in BrazeUICompat #57

Closed wajeehUlH closed 1 year ago

wajeehUlH commented 1 year ago

Platform

iOS

Platform Version

iOS 16.2

Braze SDK Version

5.10.0

Xcode Version

14.2 (14C18)

Computer Processor

Intel

Repro Rate

100%

Steps To Reproduce

1) open ABKNewsFeedTableViewController in newsfeedui 2) select option to open web-url Simulator Screen Shot - iPhone 14 - 2023-04-04 at 14 28 40

Expected Behavior

No crash while sdk calls this method in ABKFeedWebViewController:

And line no 143: decisionHandler(WKNavigationActionPolicyCancel);

Actual Incorrect Behavior

App is crashing on

Verbose Logs

libc++abi: terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Completion handler passed to -[NSObject webView:decidePolicyForNavigationAction:decisionHandler:] was called more than once'
terminating with uncaught exception of type NSException
CoreSimulator 857.14 - Device: iPhone 14 (38F66656-6850-4AB0-89E7-3DA48A3582A1) - Runtime: iOS 16.2 (20C52) - DeviceType: iPhone 14

Additional Information

No response

wajeehUlH commented 1 year ago

NOTE: It happens when we add a wrong redirect url in news feed from Braze console. In previous Appboy sdk there is no crash the app and webpage is dismissed. Now while using BrazeUICompat app should not crash in any case either url is broken or a wrong url.

lowip commented 1 year ago

Hi @wajeehUlH,

Thank you for reporting this issue. Unfortunately, we are currently unable to reproduce this behavior.

To help with our investigation, can you provide:

Please send that information to support@braze.com, making sure to reference this GitHub issue in the email.

hokstuff commented 1 year ago

To add more information, BrazeUICompat (and BrazeKitCompat) are designed to be an in-between step to allow the host app to build during a partial migration, until the "Full Migration" could be completed.

Due to inactivity on this thread, I am closing it out. As noted above, feel free to contact the Support channels for more investigation into your issue so we can help pinpoint the root cause and aid in your migration from AppboyKit to the Swift SDK. Thanks!