braze-inc / braze-swift-sdk

Braze SDK for the Apple ecosystem, including: iOS, macOS, iPadOS, visionOS, tvOS
https://www.braze.com
Other
52 stars 19 forks source link

[Bug]: Images in ABKInAppMessageWindow Dont Scale Correctly #72

Closed virbedi closed 1 year ago

virbedi commented 1 year ago

Platform

iOS

Platform Version

iOS 16.2

Braze SDK Version

6.3.1

Xcode Version

Xcode 14.2

Computer Processor

Apple (M1)

Repro Rate

100%

Steps To Reproduce

  1. Replace Appboy-iOS-SDK with BrazeKitCompat 6.3.1 and BrazeUICompat 6.3.1 in podfile and import statements across the app
  2. View a full screen modal using the ABKInAppMessageWindow.

Expected Behavior

The header image at the top of the modal should scale to fit the entire width of the modal.

Actual Incorrect Behavior

The Image is scaled differently and display in the center instead of the entire width of the modal. Before and After images when using Appboy-iOS-SDK', '~> 4.1.0' vs BrazeKitCompat 6.3.1

Screenshot 2023-07-19 at 4 19 58 PM

Verbose Logs

No response

Additional Information

We are trying to migrate from the older AppBoy SDK to the new BrazeKit SDK and would like to use the Compat libraries before we migrate fully to the new SDK.

The images as part of our UI are not scaling as they were before. The only changes made were to the import statements and Podfile as per the Migration Guide

lowip commented 1 year ago

Hi @virbedi,

Thank you for opening this issue. Could you upload the specific image on this thread? We need to make sure we reproduce in the same conditions.

virbedi commented 1 year ago

Here's the image that is uploaded to the Braze Dashboard.

lowip commented 1 year ago

@virbedi,

Thank you for providing this asset. We've identified the issue and are reviewing a fix that should be part of the next release. In the meantime, you can pin your dependency 5.14.0 which does not suffer from that issue.

We'll update here once the fix is available.

virbedi commented 1 year ago

Thanks for the quick response. I'll give 5.14.0 a try in the mean time.

lowip commented 1 year ago

Hi @virbedi,

We have released 6.4.0 which includes the fix for this issue.

Best,