search

braze-inc / braze-web-sdk

Public repo for the Braze Web SDK
https://www.braze.com
Other
71 stars 25 forks source link

Question: use only CustomHtml In app message, do library still need to load fontawesome ? #89

Closed corelationNut closed 4 years ago

corelationNut commented 4 years ago

Hi, Regarding from document: https://js.appboycdn.com/web-sdk/2.7/doc/module-appboy.html

doNotLoadFontAwesome - Braze uses FontAwesome for in-app message icons. By default, Braze will automatically load FontAwesome 4.7.0 from the FontAwesome CDN. To disable this behavior (e.g. because your site uses a customized version of FontAwesome), set this option to true. Note that if you do this, you are responsible for ensuring that FontAwesome is loaded on your site - otherwise in-app messages may not render correctly.

But we're planning to do custom html in app message only (no using icons), are we still need to load fontawesome ? If we're not load it at all for custom html, is it going to has a side effect ?

PS. (we want to get rid of it for improve performance loading and conflict library to our library in future)

Thanks

froodian commented 4 years ago

Hi @corelationNut - it should be safe to forgo loading FontAwesome in the scenario you describe - as long as you are using a recent SDK version (>2.3.0), and this icon functionality for native in-app message types is never used within the braze dashboard:

image

If somebody does compose and send a message using one of those icons ("badges") it will appear broken without FontAwesome. It sounds like you're not planning on doing that though.

corelationNut commented 4 years ago

@froodian Thanks for confirmation !