brcdev
commented
1 year ago Hello!
I understand your and the other developer's point, but due to the way ShopGUI+ handles its own dependencies (and the fact is must ensure they are loaded before it enables itself, where i.e. HeadDatabase also loads its heads after the server is loaded and players already can join) this behaviour can't be changed. As a result, there's the ShopGUIPlusPostEnableEvent even that should be used instead.
As you have already noticed in the other ticket, there is an example showing the correct & safe way to hook included in readme of this repo we're currently in. I've also added another example of how one can ensure shops are loaded.
I will leave this ticket open for now, but I don't really see any way we could improve it on our end, especially until other plugins hook into ShopGUI+ the recommended way.
Distolfix
Dear developer,
I am writing to inform you that your plugin has a problem that prevents it from working with SuperiorSkyblock2. At the end of this message, I will send you a GitHub link that I kindly ask you to respond to, as I am also in contact with the developer of the skylock to solve this problem. The bug is in your plugin i think.
The issue is that the skyblock plugin requests the prices of your shop for the "is top" function, but your plugin loads the shops after the server leaves a "Done" message. If a player enters while the server is still loading, an error occurs because your plugin has not yet loaded the shops and it appears that they do not exist. Please read the GitHub link I am sending you and kindly respond to it.
https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1645#issuecomment-1483816236
Thank you.